Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Approximate NURBS Curve - FreeCAD" node #4880

Closed
portnov opened this issue Jan 23, 2023 · 4 comments
Closed

"Approximate NURBS Curve - FreeCAD" node #4880

portnov opened this issue Jan 23, 2023 · 4 comments
Assignees
@portnov
Labels
NURBS

Comments

@portnov
Copy link
Collaborator

portnov commented Jan 23, 2023

No description provided.

@portnov portnov added the NURBS label Jan 23, 2023
@portnov portnov self-assigned this Jan 23, 2023
@rendetto
Copy link
Contributor

rendetto commented Jan 23, 2023 •
edited
Loading

@portnov Are you about to implement it already?

I'm pretty close to do it also :D

FC_Approximate_Curve

@portnov
Copy link
Collaborator Author

portnov commented Jan 23, 2023

No, I just created an issue to do not forget that I wanted to :)

@rendetto
Copy link
Contributor

rendetto commented Jan 23, 2023 •
edited
Loading

Perfect! I'm almost there, just need to make some tweaks. I found several approximation methods on OCCT and tested the PointsToBSpline (the above screenshot which I'm about to implement) and the ApproximateWire (which was not so good):
FC_approx_wire

So I guess I'll need a day or so, in case everything goes smoothly :)

@rendetto
Copy link
Contributor

rendetto commented Jan 25, 2023 •
edited
Loading

@portnov I shared up a PR #4881. Hopefully I didn't mess the node up :)

@portnov portnov closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@portnov portnov

Labels
NURBS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@portnov @rendetto