-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Approximate NURBS Curve" node FreeCAD implementation #4881
"Approximate NURBS Curve" node FreeCAD implementation #4881
Conversation
..and minor code decoration changes
I need some help with the docs. I'm not sure what I'm doing wrong so that this check is constantly failing. |
That's weird because match.rst it's not part of this PR. |
@nortikin Should I try fixing match.rst? I saw you did the last changes. EDIT: Fixed! :) |
Added the "Explicit Knots" method description and some minor changes.
@rendetto it seems you have to rebase this branch to master:
|
Ah, merge worked as well :) |
@portnov is it possible to merge it already? I've done all the changes I was planning. Thanks |
Suggestions:
|
It's fine IMHO. |
Thanks. I've updated the docs accordingly. It should be ready for merge. |
This PR adds the PointsToBSpline OCCT method from FreeCAD for approximating points to a NURBS curve.
Example of Chord Length Parametrization:
Example of using Variational Smoothing:
EDIT:
I added an option where we can specify the knots explicitly:
The cool thing here is that we can utilize the "Generate Knotvector" node and use the metrics from it.