Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile node: Interpolation command #4776

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Profile node: Interpolation command #4776

merged 3 commits into from
Nov 28, 2022

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Nov 28, 2022

This adds a new command, @I / @i, to the syntax of Profile Mk3 node definitions.

@I / @i command is an extension of SVG syntax. It defines a curve as
interpolating NURBS curve through the provided list of points. Current point,
at which the pen is located at the start of command, will be considered as
first point to be interpolated. If z is specified in the end, the curve will
be closed (cyclic); otherwise, this command will define an open curve. If
special keyword, @smooth, is specified, then, while computing interpolation
curve, this command will consider previous curve segment, defined by previous
command (C/c, S/s, Q/q, T/t), if it is of the same degree, and draw the curve
in such a way that in the starting point it will have the same tangent vector,
as previous curve had in the end point; in other words, at the meeting point of
segments, the curve will be smooth. Providing z and @smooth for the same
@i command is not supported.

Screenshot_20221128_231313
Screenshot_20221128_230736
Screenshot_20221128_232046

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov merged commit 41c2872 into master Nov 28, 2022
@portnov portnov deleted the profile_interpolate branch November 28, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant