Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4837 (crash Blender if only first vertex in vertices list is empty) #4838

Merged
merged 6 commits into from
Jul 18, 2023
Merged

fix #4837 (crash Blender if only first vertex in vertices list is empty) #4838

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
037ccd0
fix #4837 (crash Blender if only first vertex in vertices list is emp…
satabol Dec 23, 2022
df0c680
errata
satabol Dec 24, 2022
a7497a8
fix if ==True
satabol Jul 5, 2023
7d99bbf
fix useless "else"
satabol Jul 6, 2023
e15ba46
Restore bgl.glDisable
satabol Jul 6, 2023
f808696
PEP8
satabol Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions nodes/viz/viewer_draw_mk4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,20 @@ def view_3d_geom(context, args):
bgl.glLineWidth(1)

if config.draw_verts:
bgl.glPointSize(config.point_size)
if config.uniform_verts:
v_batch = batch_for_shader(config.v_shader, 'POINTS', {"pos": geom.v_vertices})
config.v_shader.bind()
config.v_shader.uniform_float("color", config.vector_color[0][0])
else:
v_batch = batch_for_shader(config.v_shader, 'POINTS', {"pos": geom.v_vertices, "color": geom.points_color})
config.v_shader.bind()
if geom.v_vertices and (len(geom.v_vertices[0])==3):
bgl.glPointSize(config.point_size)
if config.uniform_verts:
v_batch = batch_for_shader(config.v_shader, 'POINTS', {"pos": geom.v_vertices})
config.v_shader.bind()
config.v_shader.uniform_float("color", config.vector_color[0][0])
else:
v_batch = batch_for_shader(config.v_shader, 'POINTS', {"pos": geom.v_vertices, "color": geom.points_color})
config.v_shader.bind()

v_batch.draw(config.v_shader)
bgl.glPointSize(1)
v_batch.draw(config.v_shader)
bgl.glPointSize(1)

bgl.glEnable(bgl.GL_BLEND)
bgl.glDisable(bgl.GL_BLEND)


def splitted_polygons_geom(polygon_indices, original_idx, v_path, cols, idx_offset):
Expand Down