"Curve mapper": respect "use clipping" option. #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier we used https://docs.blender.org/api/current/bpy.types.CurveMapping.html#bpy.types.CurveMapping.evaluate method to calculate the resulting value of mapper, in hope that it respects clipping settings automatically. However, it appears to do not. As a result, if the curve goes, for example, beyond [0;1] by Y, the result of the curve mapper could go negative even though "use clipping" option in the curve widget is enabled. This change adds explicit clipping to evaluate function. If someone happened to adapt previous behaviour, they can just untick the "use clipping" checkbox in the curve widget settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we used
https://docs.blender.org/api/current/bpy.types.CurveMapping.html#bpy.types.CurveMapping.evaluate method to calculate the resulting value of mapper, in hope that it respects clipping settings automatically. However, it appears to do not. As a result, if the curve goes, for example, beyond [0;1] by Y, the result of the curve mapper could go negative even though "use clipping" option in the curve widget is enabled.
This change adds explicit clipping to evaluate function. If someone happened to adapt previous behaviour, they can just untick the "use clipping" checkbox in the curve widget settings.
Clipping enabled:
the same curve with disabled clipping:
Preflight checklist
Put an x letter in each brackets when you're done this item: