crypto: fix webcrypto RSA generateKey() use of publicExponent

PR-URL: nodejs/node#43431 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
noslate-project · Oct 10, 2022 · 0172b8c · 0172b8c
1 parent 0a78d7c
commit 0172b8c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/lib/internal/crypto/rsa.js b/lib/internal/crypto/rsa.js
@@ -176,7 +176,7 @@ async function rsaKeyGenerate(
   return new Promise((resolve, reject) => {
     generateKeyPair('rsa', {
       modulusLength,
-      publicExponentConverted,
+      publicExponent: publicExponentConverted,
     }, (err, pubKey, privKey) => {
       if (err) {
         return reject(lazyDOMException(

diff --git a/test/parallel/test-webcrypto-keygen.js b/test/parallel/test-webcrypto-keygen.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 const common = require('../common');
@@ -10,8 +11,11 @@ const { types: { isCryptoKey } } = require('util');
 const {
   webcrypto: { subtle, CryptoKey },
   createSecretKey,
+  KeyObject,
 } = require('crypto');
 
+const { bigIntArrayToUnsignedBigInt } = require('internal/crypto/util');
+
 const allUsages = [
   'encrypt',
   'decrypt',
@@ -264,10 +268,16 @@ const vectors = {
     assert.strictEqual(publicKey.algorithm.name, name);
     assert.strictEqual(publicKey.algorithm.modulusLength, modulusLength);
     assert.deepStrictEqual(publicKey.algorithm.publicExponent, publicExponent);
+    assert.strictEqual(
+      KeyObject.from(publicKey).asymmetricKeyDetails.publicExponent,
+      bigIntArrayToUnsignedBigInt(publicExponent));
     assert.strictEqual(publicKey.algorithm.hash.name, hash);
     assert.strictEqual(privateKey.algorithm.name, name);
     assert.strictEqual(privateKey.algorithm.modulusLength, modulusLength);
     assert.deepStrictEqual(privateKey.algorithm.publicExponent, publicExponent);
+    assert.strictEqual(
+      KeyObject.from(privateKey).asymmetricKeyDetails.publicExponent,
+      bigIntArrayToUnsignedBigInt(publicExponent));
     assert.strictEqual(privateKey.algorithm.hash.name, hash);
 
     // Missing parameters
@@ -344,6 +354,17 @@ const vectors = {
         code: 'ERR_INVALID_ARG_TYPE'
       });
     }));
+
+    await Promise.all([[1], [1, 0, 0]].map((publicExponent) => {
+      return assert.rejects(subtle.generateKey({
+        name,
+        modulusLength,
+        publicExponent: new Uint8Array(publicExponent),
+        hash
+      }, true, usages), {
+        name: 'OperationError',
+      });
+    }));
   }
 
   const kTests = [