[NIP90] - replace NIP04 encryption with NIP44 encryption for encrypted jobs #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
believethehype
changed the title
|
We're gonna do this or nah? |
|
Amethyst is following the change on NIP-46 #1248 (comment). Right now we test if the encrypted payload is nip04 or nip44 and decrypt it either way. But we still encrypt in NIP-04 to wait for DVMs to catch up. Once DVMs are ready with NIP-44, we can encrypt to nip-44 and disable nip-04 decryption. |
|
Coracle/welshman don't use encrypted jobs, so this doesn't affect me. |
|
My DVMs could do Nip44 but I kept them on Nip04 because Nip90 says Nip04. Thats why I was adding this PR back then to move to Nip44. If clients support both, its good, but for future development, the question is what we want to move on with and the Nip should point both dvm and client devs to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are considerations to fully replace nip04 with nip44 encryption and major libraries used for DVMs like rust-nostr and ndk already support nip44 en/decryption this PR suggests replacing nip04 encryption for "encrypted jobs" with nip44 encryption. This only concerns jobs that are encrypted aka use the "encrypted" tag.