Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to load an OBJ mesh with texture #684

Closed
wants to merge 1 commit into from
Closed

Add a function to load an OBJ mesh with texture #684

wants to merge 1 commit into from

Conversation

0x177
Copy link
Contributor

@0x177 0x177 commented Jan 10, 2024

a comment on the top of model.rs mentions loading models, but there isn't any code that does that, so i added it. this function is probably slow and i don't like the tobj dependency, but it is easy and less bloated than other obj parsers.

Blender monkey with brick texture applied
Blender monkey with brick texture applied

@not-fl3
Copy link
Owner

not-fl3 commented Jan 11, 2024

Hi, thanks for PR!

Tho I am not quite sure if this code justify adding an extra dependency - user can always use tobj directly, its not that much code to get tobj data into macroquad's model.
And, lets be honest, macroquad is not really very good for 3d anyway, so making every single user to compile tobj all the time might be a bit of an overkill here.

@0x177
Copy link
Contributor Author

0x177 commented Jan 11, 2024

Hello!

i agree. only vertices are used here so it would be pretty easy to add a small parser, but considering macroquad's 3d capabilities, it realistically wouldn't be used by anyone (plus it is easy to just use tobj as you said).

@0x177 0x177 closed this by deleting the head repository Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants