Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The notation spec link in annotation is unavailable #156

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

fanndu
Copy link
Contributor

@fanndu fanndu commented Jul 16, 2023

This is a fix to #155.
That only update the specs address in annotation in order to make the links available.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

@fanndu The commit 7f2bfa1 is not signed. Could you sign the commit and push again?

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #156 (0523d06) into main (45cdd4e) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          21       21           
  Lines        1693     1693           
=======================================
  Hits         1509     1509           
  Misses        149      149           
  Partials       35       35           
Impacted Files Coverage Δ
signature/algorithm.go 100.00% <ø> (ø)
signature/internal/base/envelope.go 97.72% <ø> (ø)
signature/jws/types.go 100.00% <ø> (ø)
signature/signer.go 96.61% <ø> (ø)
signature/types.go 0.00% <ø> (ø)
x509/cert_validations.go 82.90% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT
Copy link
Contributor

@fanndu The DCO is failing. You might want to do rebase instead of merging main.

fanndu and others added 3 commits July 21, 2023 17:11
Signed-off-by: fandu <dufann@hotmail.com>
Signed-off-by: fanndu <dufann@hotmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 0c1ec3b into notaryproject:main Jul 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants