feat: add new registry interface and renam Link

Signed-off-by: Binbin Li <libinbin@microsoft.com>
notaryproject · Jun 24, 2022 · e391237 · e391237
1 parent 52fcb4a
commit e391237
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/registry/interface.go b/registry/interface.go
@@ -9,6 +9,9 @@ import (
 
 // SignatureRepository provides a storage for signatures
 type SignatureRepository interface {
+	// GetCoreSignatureManifest returns signature manifests for verification filterd by given subject digest
+	GetCoreSignatureManifest(ctx context.Context, subjectDigest digest.Digest) ([]CoreSignatureManifest, error)
+
 	// Lookup finds all signatures for the specified manifest
 	Lookup(ctx context.Context, manifestDigest digest.Digest) ([]digest.Digest, error)
 
@@ -18,6 +21,6 @@ type SignatureRepository interface {
 	// Put uploads the signature to the registry
 	Put(ctx context.Context, signature []byte) (notation.Descriptor, error)
 
-	// Link creates an signature artifact linking the manifest and the signature
-	Link(ctx context.Context, manifest, signature notation.Descriptor) (notation.Descriptor, error)
+	// CreateSignatureManifest creates an signature artifact linking the manifest and the signature
+	CreateSignatureManifest(ctx context.Context, manifest, signature notation.Descriptor) (notation.Descriptor, error)
 }
diff --git a/registry/repository.go b/registry/repository.go
@@ -24,6 +24,11 @@ type RepositoryClient struct {
 	remote.Repository
 }
 
+type CoreSignatureManifest struct {
+	Blobs       []artifactspec.Descriptor
+	Annotations map[string]string
+}
+
 // NewRepositoryClient creates a new registry client.
 func NewRepositoryClient(client remote.Client, ref registry.Reference, plainHTTP bool) *RepositoryClient {
 	return &RepositoryClient{
@@ -95,8 +100,8 @@ func (c *RepositoryClient) Put(ctx context.Context, signature []byte) (notation.
 	return notationDescriptorFromOCI(desc), nil
 }
 
-// Link creates an signature artifact linking the manifest and the signature
-func (c *RepositoryClient) Link(ctx context.Context, manifest, signature notation.Descriptor) (notation.Descriptor, error) {
+// CreateSignatureManifest creates an signature artifact linking the manifest and the signature
+func (c *RepositoryClient) CreateSignatureManifest(ctx context.Context, manifest, signature notation.Descriptor) (notation.Descriptor, error) {
 	// generate artifact manifest
 	artifact := artifactspec.Manifest{
 		MediaType:    artifactspec.MediaTypeArtifactManifest,