fix: dir package optimize #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 72.14% 71.95% -0.20%
==========================================
Files 36 36
Lines 2265 2271 +6
==========================================
Hits 1634 1634
- Misses 506 511 +5
- Partials 125 126 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
Aug 10, 2022
rgnote
reviewed
Aug 11, 2022
rgnote
reviewed
Aug 12, 2022
rgnote
reviewed
Aug 12, 2022
1. GetPath logic: if the given path doesn't exist, return the first possible in the union directories, so when create a new file the UnionDirFS will select user directory which was provided as the first directory when create the UnionDirFS 2. change the constant name Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
|
@rgnote - it seems your feedback has been addressed. Can you please take a look again and approve if all is good? |
rgnote
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible path in the union directories, so when create a new file the
UnionDirFS will select user directory which was provided as the first
directory when create the UnionDirFS
Signed-off-by: Junjie Gao junjiegao@microsoft.com