fix: dir package isolates system/user directory #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Follow up change from notaryproject#147 (comment) Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
…otaryproject#131) ## What Refactor `notation-go` to support multiple envelope types. Background can be checked in notaryproject/notation#278 I wthe whole PR into two PRs to help review, this is the first PR. More unit test cases will be added in the next PR. The whole picture is here notaryproject#146 ## Major Changes - Use package `github.com/notaryproject/notation-core-go/signature` to sign and verify. - Combine `runner` and `signer` into a `provider` for `pluginSigner` to sign and remove the `pluginSigProvider`. - Add `builtinProvider` to support local signing and `externalProvider` to support signing by plugin. - Move the payload media type and its checks to `signature` package as mentioned in notaryproject/notation-core-go#73 - Support new [keySpec](https://github.com/notaryproject/notaryproject/blob/main/signature-specification.md#algorithm-selection) and plugin contract. - Get verification plugin and version from extended attributes. - Add `SpeculateSignatureEnvelopeFormat` to inspect signature (This function may change later to better inspect a signature) - Add sign/verify from file test cases. Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com> Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com> Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
receive dirLevel for function in PathManager Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config add EnvelopeType argument.
dir package optimize: allow user define DirLevel = UserLevel | SystemLevel | UnionLevel.
refector config pacakge: receive a path argument when load and save file to allow user to overwrite the default directory structure.
Test: added unit test.
Resolves #144
Signed-off-by: Junjie Gao junjiegao@microsoft.com