Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: further clean up on notation-go #173

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

patrickzheng200
Copy link
Contributor

  1. Removed crypto, as it is already moved into notation-core-go.
  2. Removed internal/encoding.

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #173 (767fee2) into main (f35c52e) will increase coverage by 7.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   74.44%   82.31%   +7.87%     
==========================================
  Files          38       23      -15     
  Lines        2606     1815     -791     
==========================================
- Hits         1940     1494     -446     
+ Misses        521      254     -267     
+ Partials      145       67      -78     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@patrickzheng200 patrickzheng200 requested a review from a team October 20, 2022 10:54
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT requested review from gokarnm, priteshbandi and a team October 20, 2022 10:55
@yizha1 yizha1 requested a review from rgnote October 20, 2022 12:15
@shizhMSFT shizhMSFT merged commit 7ad4eca into notaryproject:main Oct 25, 2022
@patrickzheng200 patrickzheng200 deleted the cleanup-main branch October 25, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants