-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin version comparison functionality #237
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 73.25% 73.35% +0.09%
==========================================
Files 23 23
Lines 1761 1775 +14
==========================================
+ Hits 1290 1302 +12
+ Misses 376 375 -1
- Partials 95 98 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…and Verification plugin version) Signed-off-by: Jeswanth <jeshga@amazon.com>
…and Verification plugin version) Signed-off-by: Jeswanth Galla jeshga@amazon.com Signed-off-by: Jeswanth <jeshga@amazon.com>
…and Verification plugin version) Signed-off-by: Jeswanth <jeshga@amazon.com>
…and Verification plugin version Signed-off-by: Jeswanth <jeshga@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like build is failing.
585a27e
to
04ea412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve the conflicting files. |
…and Verification plugin version Signed-off-by: Jeswanth <jeshga@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensures that the the verification plugin version is higher than the minimum plugin version emitted from the signature Signed-off-by: Jeswanth <jeshga@amazon.com> Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
Ensuring that the the verification plugin version is higher than the minimum plugin version emitted from the signature