Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generate signature plugin workflow #42

Merged
merged 59 commits into from
May 18, 2022
Merged

Implement generate signature plugin workflow #42

merged 59 commits into from
May 18, 2022

Commits on Apr 26, 2022

  1. implement plugin manager 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    d0c0218 View commit details
    Browse the repository at this point in the history

  2. ignore symlinks 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    2943a57 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. fix Manager.Command 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    c33c354 View commit details
    Browse the repository at this point in the history

  2. export constants 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    5bfff33 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. pr feedback 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c09b4a1 View commit details
    Browse the repository at this point in the history

  2. improve error message 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    e1f2d49 View commit details
    Browse the repository at this point in the history

  3. move manager to its own package 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2cacb9f View commit details
    Browse the repository at this point in the history

  4. change metadata error messages 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    55fc95a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. improve the plugin manager interface 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    f0636e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. implement plugin.Run 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    b4e505d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. add plugin signer 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 2, 2022
    Configuration menu
    Copy the full SHA
    295d0bc View commit details
    Browse the repository at this point in the history

  2. improve Manager.Run 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 2, 2022
    Configuration menu
    Copy the full SHA
    e39e8ce View commit details
    Browse the repository at this point in the history

  3. base64 encode payload 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 2, 2022
    Configuration menu
    Copy the full SHA
    6307514 View commit details
    Browse the repository at this point in the history

  4. fix supported algs 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d0874d9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. create envelope 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    15d7713 View commit details
    Browse the repository at this point in the history

  2. pr feedback 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d1f6564 View commit details
    Browse the repository at this point in the history

  3. remove Command.Capability() and Command.NewResponse() 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    74dc477 View commit details
    Browse the repository at this point in the history

  4. add DescribeKey command 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    f37ca5b View commit details
    Browse the repository at this point in the history

  5. remove command validation 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    504ca16 View commit details
    Browse the repository at this point in the history

  6. plugin cleanup 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    7beb5cd View commit details
    Browse the repository at this point in the history

  7. fix compilation 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a3bdec6 View commit details
    Browse the repository at this point in the history

  8. base64 encode signature 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 3, 2022
    Configuration menu
    Copy the full SHA
    04da321 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. ignore symlinked plugin directories 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8f78a94 View commit details
    Browse the repository at this point in the history

  2. suuport plugin key spec 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bd10cfe View commit details
    Browse the repository at this point in the history

  3. pass signing payload as ascii string 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ceb9b92 View commit details
    Browse the repository at this point in the history

  4. fix rsa method 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 4, 2022
    Configuration menu
    Copy the full SHA
    26c6b91 View commit details
    Browse the repository at this point in the history

  5. define KeySpec 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 4, 2022
    Configuration menu
    Copy the full SHA
    3470557 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. add signing tests 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4d98f6d View commit details
    Browse the repository at this point in the history

  2. Bump actions/setup-go from 2 to 3 (notaryproject#32) 

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @dependabot @qmuntal
    dependabot[bot] authored and qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    01a45db View commit details
    Browse the repository at this point in the history

  3. Bump actions/cache from 2 to 3.0.1 (notaryproject#31) 

    Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.0.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v3.0.1)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @dependabot @qmuntal
    dependabot[bot] authored and qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8ea7512 View commit details
    Browse the repository at this point in the history

  4. Bump github.com/golang-jwt/jwt/v4 from 4.3.0 to 4.4.1 (notaryproject#29) 

    Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.3.0 to 4.4.1.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.3.0...v4.4.1)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @dependabot @qmuntal
    dependabot[bot] authored and qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c6553f8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/notaryproject/notation-go i… 

    …nto feat-plugins

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    7891053 View commit details
    Browse the repository at this point in the history

  6. check extension ID length and add tests 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    03b1a43 View commit details
    Browse the repository at this point in the history

  7. fail on empty certificate chain 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    7bbec7e View commit details
    Browse the repository at this point in the history

  8. create and use spec package 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c3265c3 View commit details
    Browse the repository at this point in the history

  9. dedup notaryClaim 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 5, 2022
    Configuration menu
    Copy the full SHA
    f50b242 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. remove support for multiple signature envelope 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 6, 2022
    Configuration menu
    Copy the full SHA
    c9afb7c View commit details
    Browse the repository at this point in the history

  2. move payload creation to where it's needed 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 6, 2022
    Configuration menu
    Copy the full SHA
    70877b2 View commit details
    Browse the repository at this point in the history

  3. add missing json tags 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a4981c0 View commit details
    Browse the repository at this point in the history

  4. use correct header encoding 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a2fff48 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. rename NewManager to New and add root param 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 9, 2022
    Configuration menu
    Copy the full SHA
    eb16900 View commit details
    Browse the repository at this point in the history

  2. remove artifact type from descriptor 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2a6e597 View commit details
    Browse the repository at this point in the history

  3. dedup jwt.Token creation 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 9, 2022
    Configuration menu
    Copy the full SHA
    a453d9e View commit details
    Browse the repository at this point in the history

  4. simpligy running plugin command 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 9, 2022
    Configuration menu
    Copy the full SHA
    a284a1e View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. update plugin spec 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c55f36f View commit details
    Browse the repository at this point in the history

  2. PR feedback 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 11, 2022
    Configuration menu
    Copy the full SHA
    92366fb View commit details
    Browse the repository at this point in the history

  3. check runner response type 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fc5592f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. remove spec/v1 directory 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b2c02f5 View commit details
    Browse the repository at this point in the history

  2. Revert "remove support for multiple signature envelope" 

    This reverts commit c9afb7c.

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b9246e9 View commit details
    Browse the repository at this point in the history

  3. don't check timestamp certificate 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 12, 2022
    Configuration menu
    Copy the full SHA
    cbc16f9 View commit details
    Browse the repository at this point in the history

  4. define SignatureAlgorithm in spec 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 12, 2022
    Configuration menu
    Copy the full SHA
    5e2d8ca View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Update plugin implementation with latest spec 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a24ae78 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. improve plugin error report 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 14, 2022
    Configuration menu
    Copy the full SHA
    35b4fac View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. add x5c comment 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 18, 2022
    Configuration menu
    Copy the full SHA
    8177f1c View commit details
    Browse the repository at this point in the history

  2. simplify runner interface 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 18, 2022
    Configuration menu
    Copy the full SHA
    979142f View commit details
    Browse the repository at this point in the history

  3. remove spec package 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6fe2523 View commit details
    Browse the repository at this point in the history

  4. pr feedback 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ddf72d9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Milind Gokarn <milind81@gmail.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal @gokarnm
    qmuntal and gokarnm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    cca70c9 View commit details
    Browse the repository at this point in the history

  6. fix build 

    Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
    @qmuntal
    qmuntal committed May 18, 2022
    Configuration menu
    Copy the full SHA
    07fe9b8 View commit details
    Browse the repository at this point in the history