Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to codecov.io #92

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Conversation

junczhu
Copy link
Contributor

@junczhu junczhu commented Jul 26, 2022

Fix: #93

Caution: Pending notaryproject/notation-core-go#19

Codecov Migrate Steps:

  • add coverage percent at .codecov

  • add codecov-action at build.yml (update with notation-core-go)

  • add badge at README.md

  • update make test with go test at makefile

  • update .gitignore / rmv .cover/ .test/ add coverage.txt

  • del shell/test.sh

  • del origin upload coverage report from build.yml (update with notation-core-go)

Signed-off-by: Juncheng Zhu junczhu@microsoft.com

Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
@@ -1,4 +1,7 @@
# Notation

[![codecov](https://codecov.io/gh/notatryproject/notation-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notatryproject/notation-go)
Copy link
Contributor

@shizhMSFT shizhMSFT Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![codecov](https://codecov.io/gh/notatryproject/notation-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notatryproject/notation-go)
[![codecov](https://codecov.io/gh/notaryproject/notation-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notaryproject/notation-go)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README updated

Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit cdf50d9 into notaryproject:main Jul 28, 2022
priteshbandi pushed a commit to priteshbandi/notation-go that referenced this pull request Aug 9, 2022
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to codecov.io
3 participants