refactor!: remove blob sign/verify for v1.3.0-rc.1 release #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Two-Hearts
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #1045 +/- ##
============================================
Coverage 72.00% 72.00%
============================================
Files 46 46
Lines 2300 2300
============================================
Hits 1656 1656
Misses 442 442
Partials 202 202 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Sep 27, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Two-Hearts
force-pushed
the
release-1.3
branch
from
d3ed004
to
ec32bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for
release-1.3branch.It cherry picks commit from v1.2 to remove blob sign/verify for v1.3.0-rc.1 release.
For easier review, please see https://github.com/notaryproject/notation/compare/v1.2.0..ec32bef8a58dce5447e8be43f655fe457b8272ad for your reference.