Expand plugin spec with installation details #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
force-pushed
the
plugin-lifecycle
branch
from
5fc564e
to
63bf363
Compare
SteveLasker
approved these changes
Apr 25, 2022
gokarnm
requested changes
Apr 26, 2022
specs/plugin-extensibility.md
Outdated
| To be considered a valid plugin a candidate must pass each of these "plugin candidate tests": | ||
|
|
||
| * The directory must contain an executable named `notation-{plugin-name}`. | ||
| * The executable can be a regular file or a symbolic link. |
There was a problem hiding this comment.
Symlink support expands the threat model, as there are ways to exploit them. I'd explicitly mention that we don't support symlinks for now.
There was a problem hiding this comment.
Agree, will do that.
qmuntal
force-pushed
the
plugin-lifecycle
branch
2 times, most recently
from
3097371
to
10a8fdb
Compare
gokarnm
reviewed
Apr 26, 2022
gokarnm
reviewed
Apr 26, 2022
qmuntal
force-pushed
the
plugin-lifecycle
branch
4 times, most recently
from
39b7c81
to
051af10
Compare
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
qmuntal
force-pushed
the
plugin-lifecycle
branch
from
051af10
to
ec89a5c
Compare
gokarnm
approved these changes
Apr 26, 2022
dtzar
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the plugin extensibility spec so it is more clear and specific on how a plugin is installed.
These are the detailed changes:
.exe.notation plugin listcommand, which was not in the new spec but implemented in feat-kv-extensibility.discovercommand to be considered valid.discovertoget-plugin-metadata@SteveLasker