Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requirement for codesigning and timestamping certificate #162

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Added requirement for codesigning and timestamping certificate #162

merged 1 commit into from
Jun 21, 2022

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Jun 15, 2022

Added some requirements for signing certificates and timestamping certificates.

Ref: https://hackmd.io/@pritesh/cert-chain-constraints

@priteshbandi priteshbandi changed the title Addrf requirement for codesigning and timestamping certificate Added requirement for codesigning and timestamping certificate Jun 15, 2022
@gokarnm
Copy link
Contributor

gokarnm commented Jun 16, 2022

cc: @shizhMSFT @roywill for review.

signature-specification.md Outdated Show resolved Hide resolved
signature-specification.md Outdated Show resolved Hide resolved
signature-specification.md Outdated Show resolved Hide resolved
signature-specification.md Outdated Show resolved Hide resolved
signature-specification.md Outdated Show resolved Hide resolved
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @roywill we reworded sections where you provided feedback. You can check my comments on PR for the suggested reword that was incorporated.

@NiazFK NiazFK merged commit a99fd70 into notaryproject:main Jun 21, 2022
@NiazFK NiazFK self-requested a review June 21, 2022 22:25
Copy link
Contributor

@NiazFK NiazFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants