Support for Signing scheme #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
|
Signing scheme was previously discussed #147 , in Signature spec. |
SteveLasker
reviewed
Jul 14, 2022
signing-scheme.md
Outdated
| *Q:* What is the relationship of Signing Scheme with Signature Envelope format? | ||
| *A:* Signing Scheme aims to be agnostic of the Signature Envelope format. A given signing scheme can be implemented through any signature envelope format (such as JWS or COSE) as long as it can support the required signature schema used by the signing scheme. | ||
|
|
||
| *Q:* Why trust store for Signing Authority (`x509/signingAuthority`) is distinct from trust store for Certificate Authority (`x509/ca`), why can’t they share the same trust store? |
There was a problem hiding this comment.
s/Why trust store for Signing Authority
r/Why is the trust store used for the signing authority
There was a problem hiding this comment.
@gokarnm, I'm not seeing the change here.
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
|
Added line breaks on sentences in signing-scheme.md, will format other docs as a separate PR, and addressed some of review feedback from @SteveLasker . Still to rename signing scheme values and address feedback from Roy about auditability. |
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
cc: @roywill @SteveLasker for review. |
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
Signed-off-by: Milind Gokarn <gokarnm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signingAuthoritytrust store.Signed-off-by: Milind Gokarn gokarnm@amazon.com
cc: @shizhMSFT @roywill @SteveLasker @sajayantony @priteshbandi @rgnote for review