Support arbitrary blob signing #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgnote
requested review from
gokarnm,
justincormack,
NiazFK,
priteshbandi,
SteveLasker,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
yizha1
reviewed
Nov 9, 2023
shizhMSFT
reviewed
Nov 9, 2023
Two-Hearts
reviewed
Nov 14, 2023
Two-Hearts
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Looks like changes related to trust policy version 1.1 is not included in this PR?
/cc: @yizha1 @priteshbandi
Nvm, just notice that there will be other PRs.
|
@rgnote maybe we missed the updates on the following documents |
|
|
yizha1
previously approved these changes
Nov 23, 2023
|
@yizha1 Actually, made changes to rest of the specs in this PR itself. Please review when you get a chance. https://github.com/notaryproject/specifications/blob/main/specs/signing-and-verification-workflow.md |
Two-Hearts
reviewed
Nov 27, 2023
gokarnm
requested changes
Nov 30, 2023
gokarnm
requested changes
Nov 30, 2023
shizhMSFT
reviewed
Dec 12, 2023
gokarnm
previously approved these changes
Dec 13, 2023
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
* Update threat model to add rollback attack Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
gokarnm
reviewed
Feb 27, 2024
This was referenced Mar 5, 2024
rgnote
added a commit
to notaryproject/notation
that referenced
this pull request
Mar 8, 2024
CLI Spec updated for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec and https://hackmd.io/@-KPyDkW6QfGA-pldFa13pA/ByuHffALa Signing Scheme and trust policy updates : notaryproject/specifications#283 Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com> --------- Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Cameron Rozean <rcrozean@gmail.com> Signed-off-by: Yi Zha <yizha1@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com> Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Feynman Zhou <feynmanzhou@microsoft.com> Co-authored-by: Cameron Rozean <rcrozean@gmail.com> Co-authored-by: Yi Zha <yizha1@microsoft.com> Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Co-authored-by: Milind Gokarn <milind81@gmail.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Toddy Mladenov <me@toddysm.com> Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec updates for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec
Issue : #281
Signed-off-by: rgnote 5878554+rgnote@users.noreply.github.com