Rename stretchy_buffer.h to stb_stretchy_buffer.h #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerHobbelt
pushed a commit
to GerHobbelt/stb
that referenced
this pull request
Mar 21, 2024
Merge from nothings/master now issue 169 is fixed
GerHobbelt
pushed a commit
to GerHobbelt/stb
that referenced
this pull request
Mar 21, 2024
…using different terminology -- one correctly deallocated temp memory, while the other added more deallocations in error cases. The fix is to merge the terminology of one with the new lines of code in the other.
GerHobbelt
pushed a commit
to GerHobbelt/stb
that referenced
this pull request
Mar 21, 2024
…arious issues that came up in the tests; the worst is probably an out-of-bounds write when stb_sprintf's second argument is 0. (See issue nothings#1). Details: deprecated/stb.h: * Fix crash when computing perfect hashes over a table of size 1, due to stb_log2_floor returning -1 for an input of 1 when it should only return -1 for an input of 0. * Fix undefined behavior in call to strcpy_s: The size term must be the size of the destination buffer; if it's too large, it's UB (and crashes MSVC, which assumes it can copy in chunks that large). stb_sprintf.h: * Add STBSP__ASAN definition * Fix OOB write in the case where `count == 0`. tests/grid_reachability.c: * Fix printf specifier: %d -> %zu for size_t tests/stb.c: * Fix printf specifier: %d -> %zu for size_t * Turn off code using STUA, as this does not appear to be present in current versions of stb. * Change from `__asm int 3;` to `__debugbreak()`, as the former syntax is not supported in VS 2022. test/test_ds.c: * Fix segfault: the issue was that in `arrins(temp, arrlen(temp), 'b')`, `arrins` is a macro, so `arrlen(temp)` gets inserted into multiple places; as a result, one part of the expanded macro used a size of 1 and the other used a size of 2, leading to a write at a bad index. test/test_sprintf.c: * Fix header for ssize_t on Windows tests/test_vorbis.c: * Look for sketch008.ogg in a local directory rather than hardcoding the path to it.
GerHobbelt
pushed a commit
to GerHobbelt/stb
that referenced
this pull request
Mar 21, 2024
…). Mitigate resource exhaustion attack by checking size against length of stream.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shall settle this in modern fashion!