Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AKI, SKI and keyUsage info to certificates #16

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

nothinux
Copy link
Owner

@nothinux nothinux commented Sep 3, 2023

Currently generated certificate doesn't have AKI, SKI and KeyUsage information, on this PR we adding these information the generated certificates

@nothinux nothinux changed the title feat: add AKI, SKI and keyUsage to certificates feat: add AKI, SKI and keyUsage info to certificates Sep 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #16 (e0d23e3) into master (38e4eb1) will decrease coverage by 0.13%.
The diff coverage is 65.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   71.62%   71.50%   -0.13%     
==========================================
  Files           7        7              
  Lines         962      979      +17     
==========================================
+ Hits          689      700      +11     
- Misses        217      222       +5     
- Partials       56       57       +1     
Files Changed Coverage Δ
cmd/certify/helper.go 83.69% <63.63%> (-0.85%) ⬇️
certify.go 87.39% <100.00%> (+0.10%) ⬆️

@nothinux nothinux merged commit 67ac46c into master Sep 3, 2023
@nothinux nothinux deleted the fix-aki-ski branch September 3, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants