Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ca): add ability to set custom org and expiry #5

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

nothinux
Copy link
Owner

Add ability to set custom organization and expiry in CA creation.

Resolved #4

@codecov-commenter
Copy link

Codecov Report

Merging #5 (286299c) into master (6fb2638) will increase coverage by 0.26%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   78.61%   78.87%   +0.26%     
==========================================
  Files           5        5              
  Lines         678      677       -1     
==========================================
+ Hits          533      534       +1     
  Misses        101      101              
+ Partials       44       42       -2     
Impacted Files Coverage Δ
cmd/certify/command.go 74.03% <0.00%> (-2.28%) ⬇️
cmd/certify/main.go 60.75% <ø> (ø)
cmd/certify/helper.go 83.79% <100.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nothinux nothinux merged commit 9601aad into master Dec 17, 2022
@nothinux nothinux deleted the feat-add-new-custom-ca branch December 30, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On CA generation O (organization field) is hardcoded to "certify"
2 participants