Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport some updates and bump version to 4.0.15 #232

Merged
merged 4 commits into from
Jan 2, 2020

Conversation

atouchet
Copy link
Contributor

No description provided.

@atouchet
Copy link
Contributor Author

Hrmm, still failing. I'm not sure exactly what the issue is here. If a maintainer would like to take this over feel free.

@atouchet atouchet closed this Nov 26, 2019
@0xpr03
Copy link
Member

0xpr03 commented Nov 26, 2019

Thanks for the PR, I followed your changes, but I think some tests weren't working in the first place. I'll see to that.
CC @JohnTitor

@0xpr03 0xpr03 reopened this Nov 26, 2019
@JohnTitor
Copy link
Member

Sorry for the delay! I think #236 should make v4 branch green and the failure on macOS is random so we can ignore that.

@0xpr03
Copy link
Member

0xpr03 commented Dec 25, 2019

@JohnTitor do you want to merge/rebase this ? Otherwise ping me if I haven't done this on Monday.

@JohnTitor
Copy link
Member

The change looks good, I'd like to see the check suite with rebase.

@0xpr03
Copy link
Member

0xpr03 commented Dec 25, 2019

I restartet the build.
Still would require a rebase?

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm fine to merge.

@JohnTitor JohnTitor merged commit e2214e4 into notify-rs:try-v4 Jan 2, 2020
@JohnTitor
Copy link
Member

Thanks!

@atouchet atouchet deleted the try-v4 branch January 2, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants