Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Fix missing dots in Cyrillic i and j #125

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

Mystic-Mirage
Copy link
Contributor

For some reason, Noto fonts replace Cyrillic letters i and j by dotless form -- ı and ȷ.
This is wrong and should be fixed. Here is the issue describes the problem -- googlei18n/noto-fonts#1051

I've found this behavior declared here:

script cyrl;
sub afii10103 by afii10103dotless;
sub afii10105 by afii10105dotless;

So my patch just comments out these two 'sub *' lines.

@Mystic-Mirage
Copy link
Contributor Author

Mystic-Mirage commented Jan 5, 2019

The second commit is about combining diacritics. Need to keep dot while using acute accent (for example).

Update: removed

@moyogo
Copy link
Contributor

moyogo commented Jan 5, 2019

@Mystic-Mirage The dot should be removed when used with top diacritics like the acute accent.
The characters і and ј (U+0456 and U+0458) have the soft-dotted property: https://unicode.org/cldr/utility/list-unicodeset.jsp?a=[:Soft_Dotted=Yes:]

@Mystic-Mirage
Copy link
Contributor Author

@moyogo Yes, you're right. Thank you!

I've removed the wrong commit from this PR

@Kharacternyk
Copy link

Kharacternyk commented Jun 29, 2019

Ukrainian here. Any news on it? KDE Plasma uses Noto as a default font (AFAIK, Chrome OS too) and it means that the out-of-the-box look for some users from Eastern Europe is just broken.

@Mystic-Mirage
Copy link
Contributor Author

@Kharacternyk Чекаємо...

@Mystic-Mirage
Copy link
Contributor Author

Happy 1 Year Anniversary! 🍰

@Kharacternyk
Copy link

Жах. Схоже, що nobody cares.

@marekjez86 marekjez86 merged commit 7747a4a into notofonts:master Nov 25, 2019
@rdaysky rdaysky mentioned this pull request Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants