Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ragged attention] suggested minor changes (will update the other PR if accepted) #2

Merged
merged 1 commit into from
Jan 23, 2022
Merged

[ragged attention] suggested minor changes (will update the other PR if accepted) #2

merged 1 commit into from
Jan 23, 2022

Conversation

blefaudeux
Copy link
Collaborator

@blefaudeux blefaudeux commented Jan 22, 2022 •
edited
Loading

What does this PR do?

  • add a README
  • remove a subfolder
  • remove the add/example kernel, not being used
  • remove -v2 on the folder name to fix git tracking + already in the kernel filenames and we have no v1

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@blefaudeux
Copy link
Collaborator Author

blefaudeux commented Jan 22, 2022 •
edited
Loading

f*ck, git lost the files with the duplicated folder name.. one sec again done

@blefaudeux blefaudeux force-pushed the experimental_suggestion branch 2 times, most recently from b549847 to 41137f3 Compare January 22, 2022 04:26
@blefaudeux blefaudeux mentioned this pull request Jan 22, 2022
Merged
@blefaudeux blefaudeux force-pushed the experimental_suggestion branch from 41137f3 to 5c3edca Compare January 23, 2022 17:36
@blefaudeux blefaudeux changed the title suggested minor changes (will update the other PR if accepted) [ragged attention] suggested minor changes (will update the other PR if accepted) Jan 23, 2022
@nottombrown nottombrown merged commit 885e00d into tom/experimental Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nottombrown nottombrown nottombrown approved these changes

@tomconerlyanth tomconerlyanth Awaiting requested review from tomconerlyanth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blefaudeux @nottombrown