Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Problem downloading subtitles #830

Closed
scatolo opened this issue Feb 13, 2023 · 9 comments
Closed

[Bug]: Problem downloading subtitles #830

scatolo opened this issue Feb 13, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@scatolo
Copy link

scatolo commented Feb 13, 2023

Problem description

Hi, if I try to download the subtitles directly from the player it can find them in the language I need but after that I select the one I need but then it is not selectable because it has not been downloaded. I also entered the opensubtitles credentials but I didn't solve it.

Steps to reproduce the issue

Go to any content and try to download subtitles

Expected behavior

No response

Your phone/tablet/androidTV model

Oppo Reno 6 Pro

Operating system version

Android 13

Application version and app store

6.0.97 GitHub

Additional system information

No response

Debug logs

No response

@scatolo scatolo added the bug Something isn't working label Feb 13, 2023
@baxax
Copy link

baxax commented Feb 27, 2023

It is a same problem on my machine -android tv box T95 Max+
"cant find subtitles"
-but on OpenSubtitles websites subtitles are there... I'm talking about Croatian and Serbian subtitles.

@Bigboy-thijs
Copy link

Same issue here: Mibox4 (AndroidTV)
Dutch subtitles available for download but not able to select
.

@Bigboy-thijs
Copy link

The same issue with external subtitles (srt). System recognises the subtitles but while playing the movie, subtitle is not selectable.

@courville
Copy link
Contributor

@TomiScatto please specify the language you use.

@baxax, Croatian is there but not Serbian, I am adding these language.

@courville courville self-assigned this Jun 26, 2023
@scatolo
Copy link
Author

scatolo commented Jun 26, 2023

@courville the language is Italian

@Maurs9
Copy link

Maurs9 commented Jul 12, 2023

I have same issue with an Android Tv when downloading the subtitles for the movies on a external HDD.
Note that the subtitles can be downloaded for the movies on a USB flash drive.
But also the download subtitles from VLC works for HDD.

@courville
Copy link
Contributor

OK thanks for the feedback. I understand now that it happens on local storage and we are hitting the Android restrictions introduced in the 'R' migration. In order to function properly nova would need android.permission.MANAGE_EXTERNAL_STORAGE (cf. #336). Some other players have it like vlc, mx player, etc. but nova has not been granted it yet. I will appeal again to google to see if they are more mercyful this time (cf. https://www.reddit.com/r/androiddev/comments/rmgdis/how_come_vlc_is_allowed_to_use_manage_external/).
If not, I will try to figure something else.

courville added a commit to nova-video-player/aos-FileCoreLibrary that referenced this issue Aug 17, 2023
should help in getting subs downloaded to hdd when not being able to write to it due to android R restrictions: before existence was always true resulting in not triggering the fallback to appdefaultdirectory

See nova-video-player/aos-AVP#830
@courville
Copy link
Contributor

courville commented Aug 17, 2023

Subtitles hdd download should be fixed in next release.
Note that next release will properly display subtitle track language which will help identifying subtitles tracked where subtitles are "FORCED" i.e. containing almost no subtitles (cf. https://www.rev.com/blog/subtitles-blog/what-are-forced-subtitles) which can lead to the perception that subs are not working. Moreover only subs not forced in locale language will be selected by default.
In addition, I have added the possibility to download subs in all the languages supported so far by opensubtitles (there were some missing before).

pre-release available on github to test.

@baxax
Copy link

baxax commented Aug 29, 2023

Subtitles hdd download should be fixed in next release. Note that next release will properly display subtitle track language which will help identifying subtitles tracked where subtitles are "FORCED" i.e. containing almost no subtitles (cf. https://www.rev.com/blog/subtitles-blog/what-are-forced-subtitles) which can lead to the perception that subs are not working. Moreover only subs not forced in locale language will be selected by default. In addition, I have added the possibility to download subs in all the languages supported so far by opensubtitles (there were some missing before).

pre-release available on github to test.

Thanks, that is a very good information! Ty a lot for your effort! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants