Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a friendly message if an address is scanned #247

Closed
Tbaut opened this issue Jun 17, 2019 · 1 comment · Fixed by #332
Closed

Show a friendly message if an address is scanned #247

Tbaut opened this issue Jun 17, 2019 · 1 comment · Fixed by #332
Assignees

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Jun 17, 2019

from #245

Users might be used to wallet applications that allow to scan a receiver's address to send funds to. Instead of showing a general error message, we can show a dedicated message if we detect that the QR code is in the form 0x... (20 bytes) or ethereurm:0x.. such as:

Ethereum address detected
You need to create a transaction using a software such as MyCrypto or Fether so that Parity Signer can sign it.

@Tbaut Tbaut added this to the v3.1 milestone Jul 20, 2019
@hanwencheng hanwencheng self-assigned this Aug 5, 2019
@hanwencheng
Copy link
Contributor

After some research with UOS, and talked with YJ. I think the correct place is in the rawDataToU8A function in #273 , I will implement it after that one is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants