-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QR Code Scanner Fixes #332
Conversation
src/util/decoders.js
Outdated
} | ||
var hex = hexBytes.toString(); | ||
var str = ''; | ||
for (var n = 0; n < hex.length; n += 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (var n = 0; n < hex.length; n += 2) { | |
for (let n = 0; n < hex.length; n += 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR.
Unrelated side note: We really need to add a linter to this project. The ton of nits and whitespace modifications totally dilute the real changes or the PR. I'll give it a play on my android now.
@Tbaut I agree, before I make the commit, I just do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works well. I tested with Ethereum and Substrate addresses.
Signing still works (tested on Ethereum)
works well on iOS! thank you! |
fix #247
mainly 3 fixes:
a15259d: fix a scanning user UX issue, after unavailable QR code, only trigger the scan when the user clicks the button.
b5e239f: add address detected warning.
eaf9f52: remove an unhandled promise rejection warning, code should return when error detected.