-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Parity logo on iphone #364
Comments
Logo is shown on iOS simulator, in my case it is probably because of my react-native server connection issue, I am trying to figure that problem out, at the same @yjkimjunior could you please verify that if it is the same on your device? |
You can also probably check with the Testflight version 3.0.3 |
hmm it was showing here: #362 |
Awesome then it's most probably an isolated case :) |
Bug confirmed in our live test with users, any iphone user I saw did not have the logo nor the arrow. |
I might have broken that here somewhere: https://github.com/paritytech/parity-signer/pull/352/files#diff-cccffd041a575531688c60f22ff442f8R35 |
I am thinking whether it related to the bundling process on iOS. With some codebase unrelated configuration, on my device I can see the logo, but pretty not sure which part make the differences here. |
I had a deeper look at my changes and it seems not related indeed. I mentioned to @yjkimjunior a warning that I saw recently, that I thought was because of me, but it has to do with So.. I'm clueless. edit: Just to be clear, users have tested v3.0.3 this afternoon on real iphone. I've seen 2 of them, both didn't have the logo. v3.0.4 just got approved by google, I'll ask those 2 users to test and report back 🤞 |
I just realized from a screenshot given by @hanwencheng that there's no Parity Signer logo on iphone (at the top left of the account list), and no back arrow on any other screen:
whereas on Android (it's normal to have no title on Android):
On iphone, the v2 used to have both the arrow and the title:
The text was updated successfully, but these errors were encountered: