Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Parity logo on iphone #364

Closed
Tbaut opened this issue Sep 7, 2019 · 8 comments · Fixed by #372
Closed

Missing Parity logo on iphone #364

Tbaut opened this issue Sep 7, 2019 · 8 comments · Fixed by #372
Milestone

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Sep 7, 2019

I just realized from a screenshot given by @hanwencheng that there's no Parity Signer logo on iphone (at the top left of the account list), and no back arrow on any other screen:
image
image

whereas on Android (it's normal to have no title on Android):
image

On iphone, the v2 used to have both the arrow and the title:
image

@Tbaut Tbaut added this to the v3 Substrate milestone Sep 7, 2019
@hanwencheng
Copy link
Contributor

Logo is shown on iOS simulator, in my case it is probably because of my react-native server connection issue, I am trying to figure that problem out, at the same @yjkimjunior could you please verify that if it is the same on your device?

@Tbaut
Copy link
Contributor Author

Tbaut commented Sep 7, 2019

You can also probably check with the Testflight version 3.0.3

@pmespresso
Copy link
Contributor

hmm it was showing here: #362

@Tbaut
Copy link
Contributor Author

Tbaut commented Sep 7, 2019

Awesome then it's most probably an isolated case :)

@Tbaut
Copy link
Contributor Author

Tbaut commented Sep 9, 2019

Bug confirmed in our live test with users, any iphone user I saw did not have the logo nor the arrow.

@Tbaut
Copy link
Contributor Author

Tbaut commented Sep 9, 2019

@hanwencheng
Copy link
Contributor

I am thinking whether it related to the bundling process on iOS. With some codebase unrelated configuration, on my device I can see the logo, but pretty not sure which part make the differences here.

@Tbaut
Copy link
Contributor Author

Tbaut commented Sep 9, 2019

I had a deeper look at my changes and it seems not related indeed. I mentioned to @yjkimjunior a warning that I saw recently, that I thought was because of me, but it has to do with MenuProvider and seems harmless instea/react-native-popup-menu#144

So.. I'm clueless.

edit: Just to be clear, users have tested v3.0.3 this afternoon on real iphone. I've seen 2 of them, both didn't have the logo. v3.0.4 just got approved by google, I'll ask those 2 users to test and report back 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants