Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shows the assets on iOS #372

Merged
merged 1 commit into from
Sep 11, 2019
Merged

shows the assets on iOS #372

merged 1 commit into from
Sep 11, 2019

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Sep 9, 2019

close #364

If any new static files like images and is required in the JS codebase, if order to link these static files to bundle for iOS devices, we need run yarn build-prod:ios in order to generate the updated assets folder.

Reason:
Images cannot be find in the release bundle, need to:

  1. extract the required static assets into ios/assets folder.
  2. add the references to ios/assets folder in Xcode

@hanwencheng hanwencheng changed the title Hanwen fix assets shows the assets on iOS Sep 9, 2019
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome that you found the problem. Since I couldn't reproduce, I'll let @yjkimjunior confirm.

Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the change in AppDelegate.m

other than that, I am able to see the logo and back button 👍

@Tbaut Tbaut merged commit 349d2d9 into master Sep 11, 2019
@Tbaut Tbaut deleted the hanwen-fix-assets branch September 11, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Parity logo on iphone
3 participants