Tbaut remove tab navigation #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
reviewed
Feb 25, 2019
| @@ -96,9 +90,6 @@ export class TxDetailsView extends React.PureComponent { | |||
| title={this.props.sender.name} | |||
| address={this.props.sender.address} | |||
| chainId={this.props.sender.chainId} | |||
| onPress={() => { | |||
| this.props.onPressAccount(this.props.sender); | |||
There was a problem hiding this comment.
Has there been any issues with navigation here?
(I don't think I ever wanted to navigate from tx screen to account by tapping the icon, or expected that to work that way, so I think it's fine, just curious about the reasons)
There was a problem hiding this comment.
There has been no issue opened for this indeed. I stumbled upon this and would not expect this either, hence the removal. I have the bad habit to tackle several issues at once :). I did my best not to shoot in too many directions for this one.
There was a problem hiding this comment.
I have the bad habit to tackle several issues at once :)
how sweet is it
|
have you tested the build for iOS? @Tbaut |
|
Not yet, I'll do it after #225 |
|
not the best practice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly removes the tabs (Account and Scanner) and sets the AccountList screen as the main screen.
It also fixes a couple things related to the navigation such as #142 :
Tested on Android with Tx and message signing.
There are now 2 buttons (that's at least 1 too many) on the account list, I'll tackle this (#225) in a separate PR
Question: how should I proceed to avoid committing
package-lock.json, I read it shouldn't be ingitignore.. what about this annoying wizard inpackage.json? :)