Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show seed type and green field if valid bip39 #239

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Show seed type and green field if valid bip39 #239

merged 5 commits into from
Jun 5, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented May 30, 2019 •
edited
Loading

  • add validBip39Seed to new account's state in AccountStore
  • only mark the recovery field as valid if the bip39 checksum passes
  • show in the account card the seed type
  • warn users if they recover a brain wallet (e.g no bip39 type)

Here is how it looks: (valid bip39, invalid bip39, warning)
image
image
image

@Tbaut Tbaut requested a review from maciejhirsz May 30, 2019 20:32
pmespresso
pmespresso suggested changes May 31, 2019
View reviewed changes
Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small flyby comments but works well for me!

src/components/AccountCard.js Outdated Show resolved Hide resolved
src/components/AccountCard.js Outdated Show resolved Hide resolved
maciejhirsz
maciejhirsz reviewed Jun 4, 2019
View reviewed changes
src/util/account.js Outdated Show resolved Hide resolved
maciejhirsz
maciejhirsz reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grumbles

@Tbaut Tbaut merged commit 3069957 into mh-clean-up-bindings Jun 5, 2019
@Tbaut Tbaut deleted the tbaut-seed-type-and-validation branch June 5, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejhirsz maciejhirsz maciejhirsz approved these changes

@pmespresso pmespresso Awaiting requested review from pmespresso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaut @maciejhirsz @pmespresso