-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React Native to 0.60.3 & bump react-navigation, keyboard, camera, native components. #246
Conversation
Note (from 0.60.0 onwards):
|
Builds on Android. Going to have to test with iOS later after upgrading my Xcode. |
@Tbaut at last, ready to test on android :) |
Not sure if that's an issue but I had to downgrade I get the following error (can't do a screenshot unfortunately):
edit: I saw in the commits that you must have faced exactly this error. I tried on a newly cloned repo, rebuilding everything.. (also uninstalled the app, watchman del-all, npm, yarn, rm lockfiles, react-native cli, rm nodes_modules, gradlew clean) still got the same error. I still see instances of |
this is how it works for me currently -> http://g.recordit.co/WKKrLpVbg1.gif as a last sanity check, could you manually delete the index.android.bundle file in regarding your point on compatibility, I am looking into how low we can support right now |
Ok, set minSdkVersion back to 16, tested on Nexus 5 (2013), and Pixel 2 (2017) |
Got it running as well 🎉 , taking a loot at the header style now |
got it building on ios now 🎆 |
tested on ios -> http://g.recordit.co/Y530KKSNlW.gif woop woop now i can get back to light ui :) |
Status bar fixes
Co-Authored-By: YJ <yjkimjunior@gmail.com>
Co-Authored-By: YJ <yjkimjunior@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge, and test/let test hard
No description provided.