Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump React Native to 0.60.3 & bump react-navigation, keyboard, camera, native components. #246

Merged
merged 33 commits into from
Jul 17, 2019

Conversation

pmespresso
Copy link
Contributor

No description provided.

@pmespresso pmespresso changed the title chore: bump rn to 0.59.9 chore: bump rn to 0.60.0 Jul 10, 2019
@pmespresso
Copy link
Contributor Author

pmespresso commented Jul 10, 2019

Note (from 0.60.0 onwards):

React Native CLI uses autolinking for native dependencies, but the following modules are linked manually: 
  - react-native-camera (to unlink run: "react-native unlink react-native-camera")
  - react-native-secure-storage (to unlink run: "react-native unlink react-native-secure-storage")
  - react-native-vector-icons (to unlink run: "react-native unlink react-native-vector-icons")

@pmespresso
Copy link
Contributor Author

Builds on Android. Going to have to test with iOS later after upgrading my Xcode.

@pmespresso
Copy link
Contributor Author

@pmespresso
Copy link
Contributor Author

@Tbaut at last, ready to test on android :)

@Tbaut
Copy link
Contributor

Tbaut commented Jul 15, 2019

Not sure if that's an issue but I had to downgrade minSdkVersion in android/build.gradle and app/android/build.gradle to 25 because that's my device sdk version which corresponds to android 7.1. We will need to go as low as possible because we are targeting potentially super old devices.

I get the following error (can't do a screenshot unfortunately):

Invariant Violation: The navigation prop is missing for this navigator. In
react-navigation 3 you must set up your app container directly. More info:
https://reactnavigation.org/docs/en/app-containers.html

located in Navigator (at createKeyboardAwareNavigator.js 12)
in KeyboardAwareNavigator (at App.js 62)
...

edit: I saw in the commits that you must have faced exactly this error. I tried on a newly cloned repo, rebuilding everything.. (also uninstalled the app, watchman del-all, npm, yarn, rm lockfiles, react-native cli, rm nodes_modules, gradlew clean) still got the same error. I still see instances of createKeyboardAwareNavigator in my index.android.bundle.

@pmespresso
Copy link
Contributor Author

this is how it works for me currently -> http://g.recordit.co/WKKrLpVbg1.gif

as a last sanity check, could you manually delete the index.android.bundle file in parity-signer/android/app/assets then run react-native start --reset-cache from parity-signer then refresh the app on your phone? this should regenerate the bundle.

regarding your point on compatibility, I am looking into how low we can support right now

@pmespresso
Copy link
Contributor Author

Ok, set minSdkVersion back to 16, tested on Nexus 5 (2013), and Pixel 2 (2017)

@Tbaut
Copy link
Contributor

Tbaut commented Jul 16, 2019

Got it running as well 🎉 , taking a loot at the header style now

@pmespresso
Copy link
Contributor Author

got it building on ios now 🎆

@pmespresso
Copy link
Contributor Author

tested on ios -> http://g.recordit.co/Y530KKSNlW.gif

woop woop now i can get back to light ui :)

android/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
android/gradlew.bat Outdated Show resolved Hide resolved
Tbaut and others added 2 commits July 16, 2019 22:43
Co-Authored-By: YJ <yjkimjunior@gmail.com>
Co-Authored-By: YJ <yjkimjunior@gmail.com>
@pmespresso
Copy link
Contributor Author

@Tbaut
Copy link
Contributor

Tbaut commented Jul 17, 2019

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge, and test/let test hard

@pmespresso pmespresso merged commit 15de0ff into master Jul 17, 2019
@pmespresso pmespresso deleted the yj-bump-reactnative branch July 17, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants