Make sure the recovery phrase is emptied upon process abortion #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please give it a shot, it's a small one with big impact. You could end up with an empty account in the account list if you really wished. |
|
The PR LGTM, but one more thing about the workflow of recovering an account, since create a empty account will result in nothing in the storage, I think we should prevent the user enter the pin creation page with empty seed. also according to the previous discussion, related code here, basically these situation need to be prevented from further steps, probably we should create a new issue to solve this problem. |
|
I'll separate the other small bugfix into its own PR. |
Tbaut
changed the title
|
On this PR is now as it should be, fixing one problem. |
hanwencheng
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users could set a seed for the
newaccount inAccountRecover. This seed remained in theAccountStorestate upon unmount. It needed to be manually removed in case a user doesn't finish the process.