-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard aware scroll view related problem #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well on Android. The double tap is gone and I can see the suggestions while typing 👍
Just found a couple nits.
39d7184
to
91f353c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge once YJ gives a ✔️ after an iphone test.
YJ gave the iphone to me, I will test it later today. |
fix #278
#268
Screenshots here (too big cannot upload on Github):
https://drive.google.com/file/d/1g-o_XmShquI9U52agOQUl4VBX9jBujOE/view