fix: change button default color #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaut
reviewed
Jul 29, 2019
There was a problem hiding this comment.
As mentioned in the issue in my comment, I'm really not for this neon green.
- It's not nice and 2. there's not reason for it to be green with the "valid" connotation.
We should have a look with something like https://coolors.co/1d1d1d-9e77fe-f2e364-445a6d-f9f9f9 to see what matches with the other colors.
|
What about something like edit: otherwise a little brighter, yet neutral with |
|
I am up for that bright one #48acf0, tried on device and the dark one is really confusing with the disable button. |
Tbaut
approved these changes
Jul 30, 2019
hanwencheng
force-pushed
the
hanwen-button-color
branch
from
2553913
to
be0bbbc
Compare
Tbaut
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #276.
Just use the existed neon green. Supposed the whole UI will be designed in the future.