Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrate accounts management #293

Merged
merged 43 commits into from
Aug 21, 2019
Merged

Substrate accounts management #293

merged 43 commits into from
Aug 21, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Jul 30, 2019

  • Allow creation and recovery of substrate accounts
  • Show /soft and //hard derivation path on account backup screen
  • Allow to check the derivation pathpassword for any ///password

demo
demo2

todo (another PR):

  • make sure we lock accounts as soon as we're done using the seed of an account (sign message or tx)

src/util/account.js Outdated Show resolved Hide resolved
@pmespresso pmespresso mentioned this pull request Aug 2, 2019
17 tasks
@Tbaut Tbaut mentioned this pull request Aug 7, 2019
@Tbaut Tbaut marked this pull request as ready for review August 20, 2019 08:40
@Tbaut Tbaut requested a review from pmespresso August 20, 2019 08:48
@Tbaut Tbaut merged commit be3edf8 into master Aug 21, 2019
@Tbaut Tbaut deleted the tbaut-substrate-accounts branch August 21, 2019 13:50
@pmespresso pmespresso mentioned this pull request Aug 22, 2019
17 tasks
@burdges
Copy link

burdges commented Aug 23, 2019

We might eventually want to distinguish kusama keys in which the derivation got missused paritytech/substrate#3396 although we're likely to choose to do some ugly hacks so that this can stay the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants