-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update splash screen #316
Conversation
It looks like @geastwood hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @geastwood signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for that !
Probably making it the background black is better.
absolutely, it'd be great with a background using #1d1d1d
, that's the color of the logo.
Updated the color. |
Thanks a lot, I'll let @hanwencheng test on an iphone (I don't have a mac :)) before merging |
Thanks @geastwood for the PR! Tested on iOS devices. It all looks good, I just remove a duplicated image file in 54cf3a9. And I am thinking to remove the white react native bridging splash screen on both iOS and Android, it seems we have to use the react-native-splash-screen dependency. I would suggest us to create another issue about that. |
Thanks for merging! What value does it bring to introduce |
The screenshot is only for development. And RN uses for iOS the LaunchScreen which is the essential way for implementing splash screen. Afaik, the lib makes sense when you want to show a splash screen programmatically, e.g. show an advertisement while the user is back to the app, namely hooking into the lifecycle of user interaction. |
Thanks for the explanation, we will ignore that screen then. |
PR for #313
Probably making it the background black is better.