Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update splash screen #316

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Conversation

geastwood
Copy link
Contributor

PR for #313

Probably making it the background black is better.

Screenshot 2019-08-12 at 22 32 00

@parity-cla-bot
Copy link

It looks like @geastwood hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@geastwood
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @geastwood signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for that !

Probably making it the background black is better.

absolutely, it'd be great with a background using #1d1d1d, that's the color of the logo.

@geastwood
Copy link
Contributor Author

Updated the color.

@Tbaut
Copy link
Contributor

Tbaut commented Aug 12, 2019

Thanks a lot, I'll let @hanwencheng test on an iphone (I don't have a mac :)) before merging

@hanwencheng
Copy link
Contributor

hanwencheng commented Aug 13, 2019

Thanks @geastwood for the PR! Tested on iOS devices. It all looks good, I just remove a duplicated image file in 54cf3a9.

And I am thinking to remove the white react native bridging splash screen on both iOS and Android, it seems we have to use the react-native-splash-screen dependency. I would suggest us to create another issue about that.

@Tbaut Tbaut merged commit 3cb84de into novasamatech:master Aug 14, 2019
@geastwood geastwood deleted the splash-screen branch August 14, 2019 09:11
@geastwood
Copy link
Contributor Author

Thanks for merging!

What value does it bring to introduce react-native-splash-screen?

@hanwencheng
Copy link
Contributor

It hides the white react native bridging splash screen on both iOS and Android.

Screenshot 2019-08-14 at 11 25 45

@geastwood
Copy link
Contributor Author

The screenshot is only for development. And RN uses for iOS the LaunchScreen which is the essential way for implementing splash screen. Afaik, the lib makes sense when you want to show a splash screen programmatically, e.g. show an advertisement while the user is back to the app, namely hooking into the lifecycle of user interaction.

@hanwencheng
Copy link
Contributor

Thanks for the explanation, we will ignore that screen then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants