Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor protocol #354

Merged
merged 2 commits into from
Sep 4, 2019
Merged

chore: Refactor protocol #354

merged 2 commits into from
Sep 4, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Sep 3, 2019

The property protocol is linked to a network, it should not be linked to an account directly (an account has a network key, which gives us the protocol).

  • needed for Migrate v2 #352 so that I don't have to create a protocol property for new accounts.

Tested on Android for Eth and Polka Dev account

@Tbaut Tbaut merged commit e2ab9e5 into master Sep 4, 2019
@Tbaut Tbaut deleted the tbaut-protocol-refactoring branch September 4, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants