Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only allow copying seed phrase in dev environment #365

Merged
merged 1 commit into from
Sep 7, 2019
Merged

fix: only allow copying seed phrase in dev environment #365

merged 1 commit into from
Sep 7, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Sep 7, 2019 •
edited
Loading

closes #363

  • allow seed phrase copy only for dev environment
  • show the "copy these words" at any time, not only at account creation.

edit: tested by building an apk, nothing happen on press as expected.

@pmespresso pmespresso merged commit bb8ecc4 into master Sep 7, 2019
@pmespresso pmespresso deleted the tbaut-prevent-copy branch September 7, 2019 17:15
@Tbaut Tbaut mentioned this pull request Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanwencheng hanwencheng Awaiting requested review from hanwencheng

@pmespresso pmespresso Awaiting requested review from pmespresso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy behavior inconsistently for Substrate and Ethereum accounts
2 participants
@Tbaut @pmespresso