Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove git restrictions with pre-git and add semantic validator for pr #397

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

hanwencheng
Copy link
Contributor

Description

  1. remove any restrictions on commit
  2. add semantic validator to add the following types in front of the PR as what we do before with commit. @goldsteinsveta

Additional Configurartions

Since I can not change the settings of the repo, to use it we still need to do followings administration with this repo:
Install Semantic Pull Request on Github, start here.

Another thing is that I suggest we only allow Squash Merging under merge button.

Trouble Shooting

If after this PR you still met the restrictions with commit, please delete git hook repository

$parity-signer    rm -rf  .git/hooks/

@Tbaut
Copy link
Contributor

Tbaut commented Oct 3, 2019

Another thing is that I suggest we only allow Squash Merging under merge button.

Not entirely sure why we would use the others, but since squash-merge is the default I don't really mind keeping the other options in case it can help. There's no overhead.

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, I installed semantic-pull-requests on the repo :)

@hanwencheng hanwencheng merged commit c0dbfb3 into master Oct 4, 2019
@hanwencheng hanwencheng deleted the hanwen-git-hook branch October 4, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants