feat: UOS Multipart

[pmespresso]

#322

Starting with a utf8 message as this is most likely how a metadata blob will be transferred (#318). It would however be rather useful to add an extension range specifically for metadata payloads, although on the other hand metadata injection would probably only be with regard to Substrate based chains. @maciejhirsz?

Particularly because the UOS spec says that 7B is a forbidden first byte of any part_data, but that is how a metadata struct/json is going to be transfered.

• - Multipart:
  • - Cold Signer MUST be able to start scanning the Multipart Payload at any frame.
  • - Cold Signer MUST NOT expect the frames to come in any particular order.
  • - Cold Signer SHOULD show a progress indicator of how many frames it has successfully scanned out of the total count.
  • - part_data MUST be stored by the Cold Signer, ordered by frame number, until all frames are scanned.
  • - Once all frames are combined, the part_data must be concatenated into a single binary blob, and then interpreted as a completely new albeit larger Payload, starting from the prefix table above.

[Tbaut]

Could you add the instructions to test it? I've played with the current state of https://uostestqrs.herokuapp.com/ but it's a 26 frames (with long frame time) so I couldn't actually test it because it would take super long.

We somehow need to reset the isMultipart and/or frameCount at component unmount because say you start scanning a multipart, and you abort it for some reason (just like I did). You exit the scanner and get back to it, it'll still show the frame count and the "Multipart scanning, hold still.." although I'm not scanning anything any more.

[Tbaut]

Thanks, please ping me for review when you think it's good to go.

[pmespresso]

testing contract upload on Substrate so will need to uncomment the Substrate stuff before testing. it is 15 frames to upload incrementer contract.

[pmespresso]

hi, @Tbaut the multipart pr is ready for review again. You can test with the random message in the herokuapp, and you can test with system.setCode with flipper.wasm or something in polkadot/apps too (beware, it'll be 13 frames)

[pmespresso]

system.setCode(flipper.wasm)

[Tbaut]

I tried the message without having the proper account on my phone and get this warning (because the account can't be found):

But more weirdly, I scanned a sudo transaction after this, and went back without signing it, then scanned the message multipart again, and now although I'm scanning the multipart (still without the account) I'm taken to the sudo tx confirmation screen.

[Tbaut]

Message scanning is working well!
For contracts I get the unhandled promise rejection

or things like "unable to parse transaction":

[pmespresso]

Hey @Tbaut thanks for all the testing! As we discussed yesterday, I've now archived the UOS-QRs repo and heroku app as it was originally a placeholder while the QR support was being added to apps.

From what I've tested, system.setCode with some small wasm file works on apps master, I'd appreciate if you tested on apps directly

[pmespresso]

error codes for reference.

/// An invalid transaction validity.
#[derive(Clone, PartialEq, Eq, Encode, Decode, Copy)]
#[cfg_attr(feature = "std", derive(Debug, serde::Serialize))]
pub enum InvalidTransaction {
	/// The call of the transaction is not expected.
	Call,
	/// General error to do with the inability to pay some fees (e.g. account balance too low).
	Payment,
	/// General error to do with the transaction not yet being valid (e.g. nonce too high).
	Future,
	/// General error to do with the transaction being outdated (e.g. nonce too low).
	Stale,
	/// General error to do with the transaction's proofs (e.g. signature).
	BadProof,
	/// The transaction birth block is ancient.
	AncientBirthBlock,
	/// The transaction would exhaust the resources of current block.
	///
	/// The transaction might be valid, but there are not enough resources left in the current block.
	ExhaustsResources,
	/// Any other custom invalid validity that is not covered by this enum.
	Custom(u8),
}

tldr Invalid Transaction Payment = good, InvalidTransaction BadProof = bad

[pmespresso]

Took a while to figure out what Invalid Trasaction: Custom(2) meant, but it means no permission since only these modules are allowed. https://github.com/paritytech/polkadot/blob/05b1c16802ab9e6dfc0e2542c69adf5bd8e7d729/runtime/src/lib.rs#L134

[Tbaut]

Multipart seems to work well, logging some more related issues but we can merge this one in the mean time.
Signing and sending TX still works well (tested on Ehtereum and Dev Substrate)