Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Header and upgrade gradle #449

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fix: Header and upgrade gradle #449

merged 1 commit into from
Oct 31, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Oct 31, 2019

The header brings back the usual behavior on Android of not having any header title. Please make sure that it looks ok on iphone (the home as well as the other screens).

Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, but I wonder why we put the static navigationOptions { title: 'Title' } everywhere just to then set it to display: none. Can't we just remove that?

@pmespresso
Copy link
Contributor

LGTM

@pmespresso pmespresso merged commit c660327 into master Oct 31, 2019
@pmespresso pmespresso deleted the tbaut-header-gradle branch October 31, 2019 11:39
@hanwencheng
Copy link
Contributor

Will remove the title in the HDKD PR as well.

pmespresso pushed a commit that referenced this pull request Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo over "Accounts"
3 participants