Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Eslint now works on root folder #453

Merged
merged 2 commits into from
Nov 1, 2019
Merged

chore: Eslint now works on root folder #453

merged 2 commits into from
Nov 1, 2019

Conversation

hanwencheng
Copy link
Contributor

  • lint all the files start from root folder
  • use .gitignore file as ignore-path for Eslint
  • disable non-undef for e2e test file with global jasmine and jest variables.
  • fixes the error related.

pmespresso
pmespresso approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@pmespresso pmespresso merged commit ada1680 into master Nov 1, 2019
@pmespresso pmespresso deleted the hanwen-eslint-fix2 branch November 1, 2019 16:51
pmespresso pushed a commit that referenced this pull request Nov 9, 2019
@hanwencheng @pmespresso
chore: Eslint now works on root folder (#453)
7418688 
* chore: es lint with root folder

* update eslint ignore path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmespresso pmespresso pmespresso approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanwencheng @pmespresso