fix: seed recovery validation and unlock fix #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwencheng
changed the title
sjeohp-zz
previously approved these changes
Nov 27, 2019
Closed
Tbaut
previously approved these changes
Nov 28, 2019
| setIsSeedValid(validateSeed(inputSeedPhrase, bip39)); | ||
| }) | ||
| .catch(() => setIsSeedValid(inputSeedPhrase, false)); | ||
| const debouncedAddressGeneration = debounce(addressGeneration, 200); |
There was a problem hiding this comment.
This debounce isn't working. I remember struggling a lot with it in the past (in screens/AccountRecover.js).
To verify what I said, add a console.log in addressGeneration, you'll see that it's printed at every key stroke. I couldn't manage to make it work in a reasonable time in this component though :(.
There was a problem hiding this comment.
true, let me have a try.
There was a problem hiding this comment.
updated, in debounce.js we create new instance of timeout at each call of debounce, so that it is not cleared.
Tbaut
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #461 .
tested with brain wallet seed with extra space: