fix: Support cc3 #481
Merged
fix: Support cc3 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tbaut
commented
Dec 2, 2019
•
Tbaut
commented
- closes Update Kusama to CC3 and Metadata v9 #479
pmespresso
reviewed
Dec 2, 2019
hanwencheng
reviewed
Dec 2, 2019
| @@ -46,13 +45,12 @@ const SUBSTRATE_ID = new Uint8Array([0x53]); | |||
| const CRYPTO_SR25519 = new Uint8Array([0x01]); | |||
| const CMD_SIGN_MORTAL = new Uint8Array([0]); | |||
| const CMD_SIGN_MSG = new Uint8Array([3]); | |||
| const registry = new TypeRegistry(); | |||
| new MetaData(registry, kusamaData); | |||
There was a problem hiding this comment.
This new part is not nice, and trigger an eslint warning of do not use new with side effect, but before figure it out with Jaco, let us use this to fix the current problem.
The way of registry.setMetaData(new MetaData(registry, kusamaData)) does not work and give an error.
Tbaut
commented
Dec 2, 2019
hanwencheng
previously approved these changes
Dec 2, 2019
|
Let me fix the tests |
hanwencheng
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.