Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extra height, focus, suggestions in text input #505

Merged
merged 1 commit into from
Dec 21, 2019
Merged

fix: extra height, focus, suggestions in text input #505

merged 1 commit into from
Dec 21, 2019

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Dec 19, 2019 •
edited
Loading

closes #485

Imporve text input on Identity New, Identity Pin and Path Derivation screen.

  • remove autofocus for Identity New and Path Derivation screen.
  • remove suggestions when creating path and when recovering identity
  • adjust extra height for keyboard scroll view which enble showing confirm button on small screen devices. (Basically, for every KeyboardScrollView, the extraHeight need to be specified to enble scroll up the screen for focused text input)
Android Ios
out out_ios

How to test

On a small screen device, try the text input in the following screens

  • recover identity with seed.
  • generate new seed.
  • unlock account with pin.

Tbaut
Tbaut approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ack, code looks good

@hanwencheng hanwencheng merged commit fc08ceb into master Dec 21, 2019
@hanwencheng hanwencheng deleted the hanwen-fix-keyboard branch December 21, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@sjeohp-zz sjeohp-zz Awaiting requested review from sjeohp-zz

@pmespresso pmespresso Awaiting requested review from pmespresso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use KeyboardAwareScrollView and avoid UI covered by keyboard
2 participants
@hanwencheng @Tbaut