feat: add support for 12 mnemonic option #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwencheng
changed the title
hanwencheng
changed the title
hanwencheng
requested review from
pmespresso,
goldsteinsveta,
Tbaut and
maciejhirsz
button shoud indicate not own, but phrase's current state
goldsteinsveta
previously approved these changes
Jan 8, 2020
pmespresso
previously approved these changes
Jan 8, 2020
src/screens/IdentityBackup.js
Outdated
|
|
||
| function IdentityBackup({ navigation, accounts }) { | ||
| const [seedPhrase, setSeedPhrase] = useState(''); | ||
| const [wordsNumber, setWordsNumber] = useState(12); |
There was a problem hiding this comment.
I hate to be so nitty but I think the default should be 24 words, and power users can opt to use just a slightly less safe 12 word mnemonic. Just my opinion, not sure what Gav asked for here.
There was a problem hiding this comment.
true, the original discussion was using 12 words as an option.
hanwencheng
dismissed stale reviews from pmespresso and goldsteinsveta
via
19b0163
|
fixed with 24 words as default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #405
Behavior on iOS and Android as following:
@goldsteinsveta do you have any suggestions about the two new buttons?